Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize macro id generation #962

Merged

Conversation

TristonianJones
Copy link
Collaborator

Update the macro id generation to occur in sorted order.

This issue is somewhat difficult to trigger, but any expression
with two macros present within it should eventually trip the issue.

The test has been updated to removed some redundant conditions
which were extant once the macro tracking in the test optimizer
was fixed to reflect how macro id tracking works within the production
optimizers.

@TristonianJones TristonianJones merged commit b27008a into google:master Jun 12, 2024
2 checks passed
@TristonianJones TristonianJones deleted the stable-macro-renumber branch June 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants